-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds .opendistro-job-scheduler-lock to list of protected indices #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <[email protected]>
joshpalis
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
August 24, 2023 17:50
5 tasks
joshpalis
changed the title
Adds .opendistro-job-scheduler-lock to list of protexted indices
Adds .opendistro-job-scheduler-lock to list of protected indices
Aug 24, 2023
willyborankin
approved these changes
Aug 24, 2023
peternied
reviewed
Aug 24, 2023
peternied
approved these changes
Aug 25, 2023
peternied
pushed a commit
that referenced
this pull request
Sep 7, 2023
Backport of - #3326 - #3237 Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: HenryL27 <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
Backport of - #3326 - #3237 Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: HenryL27 <[email protected]> (cherry picked from commit f7991de)
stephen-crawford
added a commit
to stephen-crawford/security
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Stephen Crawford <[email protected]>
3 tasks
stephen-crawford
added a commit
that referenced
this pull request
Sep 12, 2023
…(reverts #3237) (#3351) ### Description - Resolves opensearch-project/job-scheduler#492 , where it was expected that the job schedule index is not protected. ### Check List - [ ] ~New functionality includes testing~ - [ ] ~New functionality has been documented~ - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Stephen Crawford <[email protected]>
DarshitChanpura
pushed a commit
to DarshitChanpura/security
that referenced
this pull request
Sep 27, 2023
…(reverts opensearch-project#3237) (opensearch-project#3351) ### Description - Resolves opensearch-project/job-scheduler#492 , where it was expected that the job schedule index is not protected. ### Check List - [ ] ~New functionality includes testing~ - [ ] ~New functionality has been documented~ - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Stephen Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Companion PR (Need to merge first) : opensearch-project/job-scheduler#474
In addition to converting the
.opendistro-job-scheduler-lock
index to a system index, adding the index name to the security plugin's list of protected indices within the linux/windows installation scripts.Issues Resolved
opensearch-project/job-scheduler#466
opensearch-project/job-scheduler#305
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.